-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AMLII-1830 Fix Flaky UDP tests #27167
base: main
Are you sure you want to change the base?
Conversation
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=37897805 --os-family=ubuntu Note: This applies to commit 62de1cd |
Regression DetectorRegression Detector ResultsRun ID: 1da03171-06c7-4513-9fc0-e8e25836dc5f Metrics dashboard Target profiles Baseline: aa64500 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI | links |
---|---|---|---|---|---|
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +1.53 | [+0.64, +2.43] | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | +1.18 | [-11.81, +14.17] | Logs |
➖ | pycheck_1000_100byte_tags | % cpu utilization | +0.99 | [-3.66, +5.63] | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.00, +0.00] | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | Logs |
➖ | file_tree | memory utilization | -0.11 | [-0.16, -0.06] | Logs |
➖ | idle | memory utilization | -0.17 | [-0.20, -0.13] | Logs |
➖ | basic_py_check | % cpu utilization | -0.62 | [-3.26, +2.02] | Logs |
➖ | otel_to_otel_logs | ingress throughput | -0.64 | [-1.45, +0.16] | Logs |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
assert.EventuallyWithT(t, func(c *assert.CollectT) { | ||
assert.Nil(t, err) | ||
assert.NotNil(t, s, "Failed to create UDP listener") | ||
}, 2*time.Minute, 2*time.Second) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, how does this help? Both s
and err
are assigned once and would not change their value after the fact. Am I missing something?
What does this PR do?
This PR add retries for some flaky tests in case a server or listener is not ready yet before testing.
Motivation
We got some reports on flaky tests here:
TestUDPReceive
TestUDPForward