-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rdnsquerier config, rate limiter, resolver and internal telemetry. #27170
base: main
Are you sure you want to change the base?
Add rdnsquerier config, rate limiter, resolver and internal telemetry. #27170
Conversation
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=38135946 --os-family=ubuntu Note: This applies to commit 73616e1 |
Regression DetectorRegression Detector ResultsRun ID: b9da06c4-aebc-4db4-8a9c-f0d86b69965e Metrics dashboard Target profiles Baseline: 1248ec4 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI | links |
---|---|---|---|---|---|
➖ | file_tree | memory utilization | +1.48 | [+1.36, +1.61] | Logs |
➖ | basic_py_check | % cpu utilization | +0.51 | [-2.24, +3.25] | Logs |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.46 | [-0.44, +1.36] | Logs |
➖ | pycheck_1000_100byte_tags | % cpu utilization | +0.26 | [-4.48, +5.00] | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.00, +0.00] | Logs |
➖ | otel_to_otel_logs | ingress throughput | -0.11 | [-0.92, +0.71] | Logs |
➖ | idle | memory utilization | -0.63 | [-0.67, -0.58] | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | -7.79 | [-20.10, +4.53] | Logs |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
770d07e
to
104d18d
Compare
104d18d
to
feb20d0
Compare
feb20d0
to
232aa8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for files owned by ASC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Jim, code LGTM, but it seems we are not adding any automated testing. Could you add tests for the component behaviour? Telemetry events, rate limit, etc..
What does this PR do?
Continues implementing rdnsquerier functionality for providing reverse DNS enrichment of private IP addresses to NDM NetFlow events. This change includes agent config for the rdnsquerier component, a rate limiter, separated out resolver, and internal telemetry.
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
No specific QA is needed for these changes because the component is disabled by default. QA has already been done to confirm that it is disabled by default and that the changes cause no difference in the agent or NDM NetFlow functionality. These changes can be tested/QAed with subsequent related changes once full reverse DNS enrichment and related configuration is supported.