Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rdnsquerier config, rate limiter, resolver and internal telemetry. #27170

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jmw51798
Copy link
Contributor

@jmw51798 jmw51798 commented Jun 28, 2024

What does this PR do?

Continues implementing rdnsquerier functionality for providing reverse DNS enrichment of private IP addresses to NDM NetFlow events. This change includes agent config for the rdnsquerier component, a rate limiter, separated out resolver, and internal telemetry.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

No specific QA is needed for these changes because the component is disabled by default. QA has already been done to confirm that it is disabled by default and that the changes cause no difference in the agent or NDM NetFlow functionality. These changes can be tested/QAed with subsequent related changes once full reverse DNS enrichment and related configuration is supported.

@jmw51798 jmw51798 added changelog/no-changelog qa/done Skip QA week as QA was done before merge and regressions are covered by tests and removed team/network-device-monitoring labels Jun 28, 2024
@pr-commenter
Copy link

pr-commenter bot commented Jun 29, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=38135946 --os-family=ubuntu

Note: This applies to commit 73616e1

@pr-commenter
Copy link

pr-commenter bot commented Jun 29, 2024

Regression Detector

Regression Detector Results

Run ID: b9da06c4-aebc-4db4-8a9c-f0d86b69965e Metrics dashboard Target profiles

Baseline: 1248ec4
Comparison: 73616e1

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI links
file_tree memory utilization +1.48 [+1.36, +1.61] Logs
basic_py_check % cpu utilization +0.51 [-2.24, +3.25] Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.46 [-0.44, +1.36] Logs
pycheck_1000_100byte_tags % cpu utilization +0.26 [-4.48, +5.00] Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.00, +0.00] Logs
otel_to_otel_logs ingress throughput -0.11 [-0.92, +0.71] Logs
idle memory utilization -0.63 [-0.67, -0.58] Logs
tcp_syslog_to_blackhole ingress throughput -7.79 [-20.10, +4.53] Logs

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@jmw51798 jmw51798 force-pushed the jmw/ndm-netflow-rdns-enrichment-async-add-config-and-rate-limiter2 branch from 770d07e to 104d18d Compare July 1, 2024 00:46
@jmw51798 jmw51798 changed the title Add rdnsquurier config, rate limiter and internal telemetry. Add rdnsquurier config, rate limiter, resolver and internal telemetry. Jul 1, 2024
@jmw51798 jmw51798 force-pushed the jmw/ndm-netflow-rdns-enrichment-async-add-config-and-rate-limiter2 branch from 104d18d to feb20d0 Compare July 1, 2024 00:55
@jmw51798 jmw51798 force-pushed the jmw/ndm-netflow-rdns-enrichment-async-add-config-and-rate-limiter2 branch from feb20d0 to 232aa8c Compare July 1, 2024 01:10
@jmw51798 jmw51798 changed the title Add rdnsquurier config, rate limiter, resolver and internal telemetry. Add rdnsquerier config, rate limiter, resolver and internal telemetry. Jul 1, 2024
@jmw51798 jmw51798 marked this pull request as ready for review July 1, 2024 01:58
@jmw51798 jmw51798 requested review from a team as code owners July 1, 2024 01:58
comp/rdnsquerier/impl/config.go Outdated Show resolved Hide resolved
comp/rdnsquerier/impl/config.go Outdated Show resolved Hide resolved
comp/rdnsquerier/impl/config.go Show resolved Hide resolved
comp/rdnsquerier/impl/config.go Outdated Show resolved Hide resolved
comp/rdnsquerier/impl/config.go Outdated Show resolved Hide resolved
comp/rdnsquerier/impl/config.go Outdated Show resolved Hide resolved
Copy link
Contributor

@ogaca-dd ogaca-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for files owned by ASC

Copy link
Member

@GustavoCaso GustavoCaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Jim, code LGTM, but it seems we are not adding any automated testing. Could you add tests for the component behaviour? Telemetry events, rate limit, etc..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/done Skip QA week as QA was done before merge and regressions are covered by tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants