Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AGENT-11268] Add a performance tuning note about increasing records per poll #44

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

jszwedko
Copy link
Contributor

Signed-off-by: Jesse Szwedko [email protected]

@jszwedko jszwedko requested a review from a team as a code owner April 12, 2024 21:52
README.md Outdated Show resolved Hide resolved
Co-authored-by: Luke Steensen <[email protected]>
tobz
tobz previously approved these changes Apr 15, 2024
estherk15
estherk15 previously approved these changes Apr 15, 2024
Copy link
Contributor

@estherk15 estherk15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added an oxford comma.

Comment on lines +114 to +117
* Update the number of records fetched per poll by setting
`consumer.override.max.poll.records` in the plugin configuration. This plugin
sends batches of records synchronously with each poll so a low number of records
per poll will reduce throughput. Consider setting this to 500 or 1000.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking, why are sentences broken up like this? Is it a formatting thing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yeah, this was just word wrapping. When it is rendered as markdown, it'll all be one line that overflows.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Esther Kim <[email protected]>
@jszwedko jszwedko merged commit c15f1d2 into master Apr 16, 2024
6 checks passed
@jszwedko jszwedko deleted the jszwedko/document-performance-tuning-poll branch April 16, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants