Encode decimal values as numeric rather than base64 #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently incoming `BigDecimal` values (e.g. from avro decoding) are encoded as base64 strings (the default) by the JsonConverter. Instead, it seems to make more sense to encode them as numeric values when publishing to Datadog. I considered making this configurable, but it seems unlikely that users would want the current behavior since it makes the data much less scruitable in Datadog. If we find this not to be the case (through an issue report) we can add a configuration option later. As it stands, I think it is a bug. Fixes: #27 Signed-off-by: Jesse Szwedko <[email protected]>
remeh
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently incoming
BigDecimalvalues (e.g. from avro decoding) areencoded as base64 strings (the default) by the JsonConverter. Instead,
it seems to make more sense to encode them as numeric values when
publishing to Datadog.
I considered making this configurable, but it seems unlikely that users
would want the current behavior since it makes the data much less
scruitable in Datadog. If we find this not to be the case (through an
issue report) we can add a configuration option later. As it stands,
I think it is a bug.
Fixes: #27
Signed-off-by: Jesse Szwedko [email protected]