added new config to allow kafka record timestamp to set as published_… #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…date event attribute
jszwedko
reviewed
Apr 25, 2024
There was a problem hiding this comment.
Thanks for this @nyk0322 ! I left a few comments but this seems like a good addition to me. I might even go so far as to say it should be the default behavior to add the timestamp, but we can start with opt-in for now to preserve the existing behavior, as you have it.
I tested it out locally and observed the records ending up in Datadog with the published_date added.
src/main/java/com/datadoghq/connect/logs/sink/DatadogLogsSinkConnectorConfig.java
Outdated
Show resolved
Hide resolved
src/test/java/com/datadoghq/connect/logs/sink/DatadogLogsApiWriterTest.java
Show resolved
Hide resolved
src/main/java/com/datadoghq/connect/logs/sink/DatadogLogsSinkConnectorConfig.java
Show resolved
Hide resolved
src/main/java/com/datadoghq/connect/logs/sink/DatadogLogsSinkConnectorConfig.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…date event attribute
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?