Add explicit permissions to all workflows #5728
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewlock
added
the
area:builds
andrewlock
commented
Jun 24, 2024
andrewlock
commented
Jun 24, 2024
lucaspimentel
approved these changes
Jun 24, 2024
andrewlock
force-pushed
the
andrew/ci/tweaks-to-github-actions
branch
from
9dacb11
to
86c37db
Compare
|
Converted to draft, as we should check to see what the monitor comes up with before committing to this |
andrewlock
added a commit
that referenced
this pull request
Jul 2, 2024
## Summary of changes - Handle code freeze a bit more easily - Allow overriding checks for integration version bump PRs ## Reason for change - We have a lot of PRs these days - Fixes a minor annoyance that the test package version bump PRs can't be merged unless you rebase/force-merge, because the checks don't automatically run ## Implementation details Mostly copy-paste ## Test coverage Meh ## Other details Moved these from #5728 so we can merge this one sooner <!-- Fixes #{issue} --> <!--鈿狅笍 Note: where possible, please obtain 2 approvals prior to merging. Unless CODEOWNERS specifies otherwise, for external teams it is typically best to have one review from a team member, and one review from apm-dotnet. Trivial changes do not require 2 reviews. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Reason for change
It's a best practice to explicitly specify required permissions for all workflows, and soon we'll have to
Implementation details
Worked through each workflow, trying to work out what it does and what permissions it needs
Test coverage
I wish
Other details
Please don't just 馃檲 approve this, it needs 馃憖 because it has the potential to break at critical times otherwise! The workflows that run as part of standard PRs should be fine, but anything that's rare/release specific needs properly understanding