-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dani/tracer/aot poc #5736
Draft
daniel-romano-DD
wants to merge
16
commits into
master
Choose a base branch
from
dani/tracer/aot_poc
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Dani/tracer/aot poc #5736
+7,480
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportBranch report: ✅ 0 Failed, 52 Passed, 0 Skipped, 34m 6.97s Total Time |
1e49a9b
to
08bd51f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Adds AotProcessor tool to instrument assemblies offline to be used in AoT compilation.
To do so, it instantiates the native Profiler and feeds it with the contents of the assembly read by a forked version of Mono.Cecil, then writes the new data into the assembly.
In order to host and call native profiler a code generator by @kevingosse has been used (thanks a lot)
Reason for change
AoT requires preinstrumented assemblies in order to generate native images. This must be done in the build pipeline. This tool is intended to be integrated there, reusing all the instrumentation that is already implemented in the native profiler.
Known issues:
CallSite works OOTB, but CallTarget needs runtime emited IL for DuckTyping. So, the pre instrumented assemblies work when executed in a managed runtime, but ducktyping would fail when executed in native, as reflection emit is disabled.