[Profiler] Fix profiler build warning #5751
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportBranch report: ❌ 7 Failed (0 Known Flaky), 342385 Passed, 1890 Skipped, 15h 28m 44.61s Total Time ❌ Failed Tests (7)
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5751) - mean (74ms) : 65, 83
. : milestone, 74,
master - mean (73ms) : 65, 82
. : milestone, 73,
section CallTarget+Inlining+NGEN
This PR (5751) - mean (897ms) : 870, 924
. : milestone, 897,
master - mean (992ms) : 971, 1012
. : milestone, 992,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5751) - mean (109ms) : 106, 113
. : milestone, 109,
master - mean (110ms) : 106, 113
. : milestone, 110,
section CallTarget+Inlining+NGEN
This PR (5751) - mean (634ms) : 618, 650
. : milestone, 634,
master - mean (706ms) : 681, 731
. : milestone, 706,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5751) - mean (93ms) : 90, 95
. : milestone, 93,
master - mean (93ms) : 90, 96
. : milestone, 93,
section CallTarget+Inlining+NGEN
This PR (5751) - mean (590ms) : 575, 605
. : milestone, 590,
master - mean (658ms) : 634, 682
. : milestone, 658,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5751) - mean (191ms) : 188, 194
. : milestone, 191,
master - mean (192ms) : 187, 197
. : milestone, 192,
section CallTarget+Inlining+NGEN
This PR (5751) - mean (1,000ms) : 971, 1030
. : milestone, 1000,
master - mean (1,090ms) : 1061, 1118
. : milestone, 1090,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5751) - mean (277ms) : 272, 281
. : milestone, 277,
master - mean (278ms) : 273, 283
. : milestone, 278,
section CallTarget+Inlining+NGEN
This PR (5751) - mean (823ms) : 791, 856
. : milestone, 823,
master - mean (878ms) : 854, 901
. : milestone, 878,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5751) - mean (266ms) : 261, 270
. : milestone, 266,
master - mean (266ms) : 262, 270
. : milestone, 266,
section CallTarget+Inlining+NGEN
This PR (5751) - mean (811ms) : 784, 837
. : milestone, 811,
master - mean (862ms) : 838, 886
. : milestone, 862,
|
Throughput/Crank Report:zap:Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5751) (11.250M) : 0, 11250000
master (11.521M) : 0, 11521470
benchmarks/2.9.0 (12.028M) : 0, 12027804
section Automatic
This PR (5751) (7.812M) : 0, 7812212
master (7.634M) : 0, 7633719
benchmarks/2.9.0 (8.471M) : 0, 8471115
section Trace stats
master (8.171M) : 0, 8170678
section Manual
This PR (5751) (9.863M) : 0, 9862764
master (10.009M) : 0, 10008600
section Manual + Automatic
This PR (5751) (7.506M) : 0, 7505970
master (7.285M) : 0, 7285173
section Version Conflict
master (6.562M) : 0, 6561604
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5751) (9.539M) : 0, 9539257
master (9.421M) : 0, 9421362
benchmarks/2.9.0 (9.556M) : 0, 9555936
section Automatic
This PR (5751) (6.654M) : 0, 6653530
master (6.538M) : 0, 6538499
section Trace stats
master (6.846M) : 0, 6845967
section Manual
This PR (5751) (8.358M) : 0, 8357605
master (8.396M) : 0, 8396114
section Manual + Automatic
This PR (5751) (6.188M) : 0, 6188485
master (6.262M) : 0, 6262289
section Version Conflict
master (5.705M) : 0, 5705337
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5751) (10.439M) : 0, 10439300
master (9.862M) : 0, 9861889
benchmarks/2.9.0 (9.885M) : 0, 9885158
section Automatic
This PR (5751) (7.224M) : 0, 7224322
master (7.083M) : 0, 7083189
benchmarks/2.9.0 (6.977M) : 0, 6977395
section Trace stats
master (7.352M) : 0, 7351962
section Manual
This PR (5751) (9.136M) : 0, 9136258
master (8.799M) : 0, 8799384
section Manual + Automatic
This PR (5751) (6.935M) : 0, 6934878
master (6.892M) : 0, 6892212
section Version Conflict
master (6.119M) : 0, 6118897
|
Benchmarks Report for tracer 🐌Benchmarks for #5751 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️Raw results
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Reason for change
Implementation details
Test coverage
Other details