Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/singing UI #23

Open
wants to merge 53 commits into
base: dev
Choose a base branch
from
Open

Feature/singing UI #23

wants to merge 53 commits into from

Conversation

DimitriosLisenko
Copy link
Owner

No description provided.

@DimitriosLisenko
Start writing library to convert frequency to note with cents offset
cb1d16e
@DimitriosLisenko
Finish implementing function that converts frequency to midi value + …
0022589 
…cents offset
@DimitriosLisenko
Two separate functions for midi values/notes to frequencies
f069a12
@DimitriosLisenko
Add class to interface with sox
d0d10df
@DimitriosLisenko
Exponent operator should have spaces around it
9c90d6b
@DimitriosLisenko
Add function to return note names of midi values in a given key
0082b25
@DimitriosLisenko
Create a command runner and use it to run sox commands to analyze a f…
d4e77c6 
…ile for frequency
@DimitriosLisenko
Should use success? instead of exited?
a044105
@DimitriosLisenko
Get rough version of frequency analysis working
52b02b4
@DimitriosLisenko
Improvement to frequency detection
ad0bbb3
@DimitriosLisenko
Add note on DFT
8494f2f
@DimitriosLisenko
Improve reading of frequency
3bbacb1
@DimitriosLisenko
Add wavefile gem
b805645
@DimitriosLisenko
Record mono
517384e
@DimitriosLisenko
Add FFI gem for interaction with C++ library
6121153
@DimitriosLisenko
Call C++ pitch detection library from Ruby
7552170
@DimitriosLisenko
Add frequency method to Fet::PitchAnalyzer to handle C pointer creation
79729fc
@DimitriosLisenko
Find a working solution for frequency detection!
1ec93e9
@DimitriosLisenko
Actually detect frequencies!
cac4d7f
@DimitriosLisenko
Use block form of FFI::MemoryPointer to automatically free memory
e197014
@DimitriosLisenko
Move the dylib file internal to the project
8d4f27c
@DimitriosLisenko
libpitch_detection.dylib compiled with openmp
4bd8b01
@DimitriosLisenko
No longer using wavefile gem
afb2169
@DimitriosLisenko
Update README.md
995fd6c
@DimitriosLisenko
Add more required dependencies
3163c85
@DimitriosLisenko
Add TODO re: delaying call to ffi_lib until required
c07275f
@DimitriosLisenko
Add more notes
37b7ab0
@codecov
Copy link

codecov bot commented Sep 21, 2021 •
edited
Loading

Codecov Report

Merging #23 (da3a19f) into dev (4aaa36c) will decrease coverage by 53.98%.
The diff coverage is 45.61%.

❗ Current head da3a19f differs from pull request most recent head 1c3743d. Consider uploading reports for the commit 1c3743d to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               dev      #23       +/-   ##
============================================
- Coverage   100.00%   46.01%   -53.99%     
============================================
  Files           69       28       -41     
  Lines         2125      778     -1347     
============================================
- Hits          2125      358     -1767     
- Misses           0      420      +420
Impacted Files Coverage Δ
lib/fet/degree.rb 48.00% <12.50%> (-52.00%) ⬇️
lib/fet/pitch_detector.rb 31.25% <31.25%> (ø)
lib/fet/degrees.rb 38.00% <33.33%> (-62.00%) ⬇️
lib/fet/frequency.rb 62.06% <62.06%> (ø)
lib/fet.rb 100.00% <100.00%> (ø)
lib/fet/midi_file_generator.rb 24.13% <0.00%> (-75.87%) ⬇️
lib/fet/generator/listening.rb 25.00% <0.00%> (-75.00%) ⬇️
lib/fet/generator/single_note_listening.rb 30.55% <0.00%> (-69.45%) ⬇️
lib/fet/cli/play/listening_command.rb 31.11% <0.00%> (-68.89%) ⬇️
lib/fet/cli/score/summary_command.rb 31.81% <0.00%> (-68.19%) ⬇️
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aaa36c...1c3743d. Read the comment docs.

@DimitriosLisenko
Add Linux shared library as well
f27e6de
@DimitriosLisenko
Add all available pitch detection methods and start fine tuning
f51376b
@DimitriosLisenko
Add TODO re: single-note listening exercises
d063f77
@DimitriosLisenko
Add logging for fine-tuning purposes
b55d52b
@DimitriosLisenko
Start making singing exercises
db64998
@DimitriosLisenko
Merge branch 'dev' of github.com:DimitriosLisenko/fet into feature/si…
31cdbe1 
…nging-ui

Conflicts:
Gemfile.lock
@DimitriosLisenko
Continue tweaking
9fab568
@DimitriosLisenko
Rough version of the singing game working
482e401
@DimitriosLisenko
Rename PitchAnalyzer to PitchDetector
a2df89f
@DimitriosLisenko
Also load .so
c80d183
@DimitriosLisenko
Handle custom events at the end of an update loop as well instead of …
dea442e 
…directly piggybacking
@DimitriosLisenko
File no longer necessary
c8b5e3e
@DimitriosLisenko
Add test for frequency and fix bug with rounding
1814c5f
@DimitriosLisenko
Make the bucket value a rational so we don't have to deal with floati…
6a00afa 
…ng point
@DimitriosLisenko
Assert difference between each bucket is 1
bd2afa6
@DimitriosLisenko
Test boundary
ef8ae87
@DimitriosLisenko
Add TODO
4205935
@DimitriosLisenko
Add note to reset @sung_times
d15f9b6
@DimitriosLisenko
Add note
783fe30
@DimitriosLisenko
Round instead of truncating the cents value
2e65946
@DimitriosLisenko
More tests around frequency calculation
ff42017
@DimitriosLisenko
Update comment
fc19fa3
@DimitriosLisenko
Lower frequency
da3a19f
@DimitriosLisenko
Fix small bug in tests
1c3743d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@DimitriosLisenko