Fix: "Use metric units" toggle has no effect and simplify sensor creation #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CM000n
changed the title
|
Hi @DurgNomis-drol, it would be great if we could merge this before adding new sensors (e.g. #222) as it includes some significant improvements to the sensor creation. Especially when dealing with metric vs non-metric units. 😉 |
|
Hi, @DurgNomis-drol, can you please take a look and approve if the changes are ok for you. 😊 |
DurgNomis-drol
approved these changes
Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #217 and add improements to sensor creation. Especially when dealy with metric vs non metric units.