Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Lexus #232

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

tibor19
Copy link
Contributor

@tibor19 tibor19 commented Jul 4, 2023

By exposing the brand as a parameter, the library can be used for Lexus as well. I have tested this with my Lexus UX300e, and works as expected.

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #232 (6cf35c7) into master (bd2ee9f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #232   +/-   ##
=======================================
  Coverage   94.64%   94.64%           
=======================================
  Files          30       30           
  Lines        1605     1607    +2     
=======================================
+ Hits         1519     1521    +2     
  Misses         86       86           
Flag Coverage Δ
unittests 94.64% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mytoyota/client.py 97.91% <ø> (ø)
mytoyota/const.py 100.00% <ø> (ø)
mytoyota/controller.py 36.84% <100.00%> (+0.55%) ⬆️
tests/test_myt.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joro75
Copy link
Collaborator

joro75 commented Jul 5, 2023

@tibor19 : Thanks for the improvements, I always expected that it was possible to also support Lexus, however I didn't have access to a Lexus to actually test it.

I have done a review, and I agree with the changes (I also fixed the unittests that were failing).
However it is up to @DurgNomis-drol to decide if we are going to support Lexus (it is OK for me).
If @DurgNomis-drol agrees, please approve the commit. :-)

@tibor19
Copy link
Contributor Author

tibor19 commented Jul 5, 2023

Thanks for the approval and the fix. I completely missed the test.

Copy link
Owner

@DurgNomis-drol DurgNomis-drol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! As Lexus is a Toyota brand I see no problem supporting it! And thanks @joro75 getting it across the finish line

@DurgNomis-drol DurgNomis-drol merged commit 912eeec into DurgNomis-drol:master Jul 7, 2023
18 checks passed
@tibor19 tibor19 deleted the add-support-for-lexus branch July 25, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants