Better Accessibility (adjusted colors and HTML elements) #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Links are underlined. - Proper landmark HTMl elements are used (nav, main, ...). - Buttons and the logo link have better contrast ratio (WCAG AAA 4.5:1). - Readonly inputs have better contrast ratio (WCAG AAA 4.5:1). - Removed `fieldset` Elements when there was no legend
- The menu items are marked as such (`role="menuitem"`). - The currently active page in the menu is marked as such (`aria-current="page"`). - The menu state is available to screen readers (`aria-expanded`). - SVG icons are hidden from screen readers, because they are purely visual (`aria-hidden="true"`) - The hamburger button is marked as a control for the menu (`aria-controls="menu"`). - The hamburger button has a localized label (*Show Menu* or *Hide Menu*).
|
Hey @Wandmalfarbe, vielen lieben Dank für die Implementierung und den Pull Request :-) Ich habe eine kleine Bitte falls du mal Zeit findest, könntest du das Auswahlmenü für die automatische Helligkeitsregelung auf Schieberegler umstellen, vielleicht nur einen Schieberegler mit zwei Punkten, da nur ein Bereich ausgewählt werden muss, in dem geregelt wird. Mit freundlichen Grüßen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better Accessibility (Adjusted Colors and HTML Elements)
fieldsetElements when there was no legendBetter Accessibility for the Menu
role="menuitem").aria-current="page").aria-expanded).aria-hidden="true")aria-controls="menu").