Birthday #398
Merged
Birthday #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementation phase 2: Before rework of Transition::isSilvester - Made 2 bugfixes for Silvester Animation - Made Uhrtypes ready for using the words "Happy Birthday"
Implementation phase 3: Almost ready, open topics: - While FireWorks switch on "Happy Birthday" (without time) - Change FireWorks interval from 5 to 60 minutes
|
Ich habe das jetzt trotz einiger Lint Fehler in einen Branch von ESPWordclock gemergt. Vielen Dank erst mal für die Hilfe mit dem Code. In den nächsten Tagen werde ich mir den Code genauer anschauen und bei mir testen, bevor er in den Main wandert. Da ich noch prüfen muss ob alles so funktioniert wie ich mir das gedacht habe und ob meine Konfliktlösung so funktioniert. Ich werde dich hier auf dem Laufenden halten. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hallo @dbambus, der Branch "Birthday" ist erneut hochgeladen (mit kleinen Nacharbeiten). Hoffentlich kannst du damit arbeiten!?