Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENTRY-86 유저 조회 API 개발
외부 서비스에서 유저 UUID로 유저 정보를 조회할 때 필요한 API를 개발합니다.
|
lilseongwon
reviewed
Sep 24, 2023
src/main/kotlin/hs/kr/equus/user/domain/user/domain/UserJpaEntity.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/hs/kr/equus/user/domain/user/service/QueryUserByUUID.kt
Outdated
Show resolved
Hide resolved
rlaisqls
reviewed
Sep 24, 2023
src/main/kotlin/hs/kr/equus/user/domain/user/mapper/UserMapper.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/hs/kr/equus/user/domain/user/service/QueryUserByUUID.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/hs/kr/equus/user/domain/user/service/UserSignupService.kt
Outdated
Show resolved
Hide resolved
Comment on lines
54
to
56
| fun findUserByUUID(@RequestParam("userId") userId: UUID): User { | ||
| return queryUserByUUID.execute(userId) | ||
| } |
There was a problem hiding this comment.
잠시 다른거랑 헷갈려서 Domain객체를 쓴 것 같습니다. 굳이 Domain이 필요 없을 것 같은데 그냥 Response DTO 쓰는게 나을까요??
rlaisqls
reviewed
Sep 24, 2023
src/main/kotlin/hs/kr/equus/user/domain/user/domain/repository/UserRepository.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: 김은빈 <[email protected]>
lilseongwon
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #ENTRY-26