Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ”€ :: (ENTRY-25) User Change Password API ๊ฐœ๋ฐœ #7

Merged
merged 9 commits into from
Sep 17, 2023
Merged

๐Ÿ”€ :: (ENTRY-25) User Change Password API ๊ฐœ๋ฐœ #7

merged 9 commits into from
Sep 17, 2023

Conversation

HyunSu1768
Copy link
Member

close #ENTRY-25

@HyunSu1768 HyunSu1768 self-assigned this Sep 14, 2023
@linear
Copy link

linear bot commented Sep 14, 2023

ENTRY-25 ์œ ์ € ๋น„๋ฐ€๋ฒˆํ˜ธ ์žฌ์„ค์ • API ๊ฐœ๋ฐœ

  • ์œ ์ € ๋น„๋ฐ€๋ฒˆํ˜ธ ์žฌ์„ค์ • API ๊ฐœ๋ฐœ
    • PassInfo ์ธ์ฆ์ด ๋์„๋•Œ๋งŒ ๊ฐ€๋Šฅ

@HyunSu1768 HyunSu1768 added the ๊ธฐ๋Šฅ ์ถ”๊ฐ€ New feature or request label Sep 14, 2023
jyk1029
jyk1029 reviewed Sep 15, 2023
View reviewed changes
src/main/kotlin/hs/kr/equus/user/domain/user/service/UserSignupService.kt Outdated
Comment on lines 35 to 36
val user = User(
id = null,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ทผ๋ฐ ๊ฐ‘์ž๊ธฐ ๊ถ๊ธˆํ•œ ๊ฒŒ ์™œ ์—ฌ๊ธฐ null์ธ๊ฐ€์š”?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ œ ์‹ค์ˆ˜์ธ ๊ฒƒ ๊ฐ™๋„ค์š”..
UUID(0, 0) ์œผ๋กœ ์ดˆ๊ธฐํ™” ํ•ด์ฃผ๊ฒ ์Šต๋‹ˆ๋‹น..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ˜น์‹œ 0,0 ์œผ๋กœ ์ดˆ๊ธฐํ™”ํ•˜๋ฉด db์— ์–ด๋–ป๊ฒŒ ์ €์žฅ๋˜๋Š”์ง€ ์•„์‹œ๋‚˜์š”

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BaseUUIDEntity์— UUID(0, 0) ์ด๋ฉด null๋กœ ๋ฐ”๊ฟ”์ค˜์„œ jpa๊ฐ€ ์ž๋™์œผ๋กœ UUID ์ƒ์„ฑํ•ด ์ฃผ๋Š”๊ฑธ๋กœ ์•Œ๊ณ ์žˆ์Šต๋‹ˆ๋‹ค

Copy link
Member

@jyk1029 jyk1029 Sep 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ทธ๋ ‡๋‹ค๋ฉด ์ง์ ‘ Random.UUID()๋ฅผ ์“ฐ์ง€ ์•Š๊ณ  (0,0)์„ ์‚ฌ์šฉํ•˜๋Š” ์ด์œ ๋Š” ๋ฌด์—‡์ธ๊ฐ€์š”?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GeneratedValue ์–ด๋…ธํ…Œ์ด์…˜์„ ๋‹ฌ์•„์„œ ์ž๋™์œผ๋กœ ID๋ฅผ ์ƒ์„ฑํ•˜๋„๋ก ํ–ˆ๊ธฐ ๋•Œ๋ฌธ์— user์—์„œ UUID(0,0) ์œผ๋กœ ์ง€์ •ํ•ด ์ฃผ๊ณ  BaseUUIDEntity์—์„œ UUID(0, 0) ์ด๋ฉด null๋กœ ๋ฐ”๊ฟ”์ฃผ์–ด JPA๊ฐ€ ์ƒ์„ฑํ•ด์ฃผ๋Š” id๋ฅผ ์‚ฌ์šฉํ•˜๋„๋ก ํ•˜์˜€์Šต๋‹ˆ๋‹ค

src/main/kotlin/hs/kr/equus/user/domain/user/domain/User.kt Outdated Show resolved Hide resolved
@lilseongwon
Copy link
Member

takeIf๋ผ๋Š” ๋ฉ”์†Œ๋“œ๊ฐ€ ์žˆ์—ˆ๋„ค์š”~ ๋•๋ถ„์— ์ €๋„ ๋ฐฐ์›Œ๊ฐ‘๋‹ˆ๋‹ค๐Ÿ‘

@HyunSu1768 HyunSu1768 merged commit f5479b6 into develop Sep 17, 2023
1 check passed
@HyunSu1768 HyunSu1768 deleted the feature/entry-25-์œ ์ €-๋น„๋ฐ€๋ฒˆํ˜ธ-์žฌ์„ค์ •-api-๊ฐœ๋ฐœ branch September 17, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyk1029 jyk1029 jyk1029 left review comments

@lilseongwon lilseongwon lilseongwon approved these changes

Assignees

@HyunSu1768 HyunSu1768

Labels
๊ธฐ๋Šฅ ์ถ”๊ฐ€ New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@HyunSu1768 @lilseongwon @jyk1029