🔀 :: (ENTRY-24) User ReIssue API 개발 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilseongwon
approved these changes
Sep 18, 2023
lilseongwon
reviewed
Sep 18, 2023
| fun reIssue(refreshToken: String): TokenResponse { | ||
| if (isNotRefreshToken(refreshToken)) { | ||
| throw InvalidTokenException | ||
| } |
There was a problem hiding this comment.
내가 저번에 확인을 못한 거 같은데 SignatureException이 있으면 좋을 거 같음. isNotRefreshToken보다는 isRefreshToken이거나 isInvalidToken 등으로 직관적인 표현을 쓰면 좋겠음(굳이 뒤에 Not 등을 넣는 건 비추. 앞에 check을 넣는 것도 추천)
There was a problem hiding this comment.
Signature exeption이 정확히 어떤걸 말하는 건가요??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #ENTRY-40