Update 2.0 #144
Merged
Update 2.0 #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SoftObjectPtr might not load the underlying asset (which it will have to anyways during the replacement) which makes the validity check not work properly.
This means that several materials could have the same identifier (eg if the user does not specify a material name in CGA and they share the same texture). But this is preferred to identify them independently because of it's indeterminism (because of the post fix numbers added to the name, which can change between different runs)
Could lead to hard to track errors if we just return an empty identifier in case a material is missing.
Necessary for packaged builds
For some reason only missing for a packaged build
Automated Asset Replacements
…ne_edit_finished Avoid regenerating buildings on spline edits in interactive mode
Improves performance for many instances
Names ending with an underscore are interpreted in a specific way by the FName constructor (the postfix number indicating a unique number of the name, which we can not guarantee).
Bneukom/cache body setup
Happened when batch generation was enabled/disabled in fast succession which caused the model to be generated both on the normal VitruvioActor as well as the BatchVitruvioActor. With this change we invalidate the (if ongoing) generate results on the BatchVitruvioActor once a VitruvioActor has been removed.
Bneukom/batch fixes
The visualizer doesn't need a physical representation in the world and is not needed in packaged builds.
We always generate collisions for generated models now.
bstegerESRI
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.