Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Unreal 5.4 #146

Merged
merged 2 commits into from
May 13, 2024
Merged

Update to Unreal 5.4 #146

merged 2 commits into from
May 13, 2024

Conversation

bneukom
Copy link
Collaborator

@bneukom bneukom commented Apr 26, 2024

No description provided.

@bneukom
Bulk update instance transforms for replacements
f8cb7ea 
Adding single instances is very slow since they update internal state every time.
bstegerESRI
bstegerESRI approved these changes May 3, 2024
View reviewed changes
Copy link
Collaborator

@bstegerESRI bstegerESRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'm not sure about the usage of TObjectPtr. I thought this should only be used for member variables which are marked with UPROPERTY.

@bneukom bneukom merged commit 9d447e5 into develop May 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bstegerESRI bstegerESRI bstegerESRI approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bneukom @bstegerESRI