smenon/edit_multiple_shapes #149
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidmenon97
commented
May 21, 2024
sidmenon97
commented
- Changes made to VitruvioComponentDetails.cpp/h
- If the RPKs for the selected objects are different, it acts as before
- Otherwise, it now allows editing the multiple selected objects simultaneously
- Added a function to get all Vitruvio Components that are selected
- Added a function to determine if the selected Vitruvio Components have different values in its field
- Modified widget functions/Added new widget functions to account for multiple values selected
bneukom
force-pushed
the
smenon/edit_multiple_shapes
branch
from
db9c0ae
to
b51d954
Compare
bneukom
approved these changes
May 27, 2024
There was a problem hiding this comment.
I rebased the PR branch to the latest changes on develop (and force pushed). Please reset your branch before making any changes :)
Very very nice work! I like how you adhered to all Unreal guidelines so well already 👍 I also did a quick test and it worked really well (will have to do a bit more indepth functional testing though after we merged it).
The comments are all relatively minor and some code style things.
Also please squash your second commit with the first one (the formatting changes).
VitruvioHost/Plugins/Vitruvio/Source/VitruvioEditor/Private/VitruvioComponentDetails.cpp
Outdated
Show resolved
Hide resolved
VitruvioHost/Plugins/Vitruvio/Source/VitruvioEditor/Private/VitruvioComponentDetails.cpp
Outdated
Show resolved
Hide resolved
VitruvioHost/Plugins/Vitruvio/Source/VitruvioEditor/Private/VitruvioComponentDetails.cpp
Outdated
Show resolved
Hide resolved
VitruvioHost/Plugins/Vitruvio/Source/VitruvioEditor/Private/VitruvioComponentDetails.cpp
Outdated
Show resolved
Hide resolved
VitruvioHost/Plugins/Vitruvio/Source/VitruvioEditor/Private/VitruvioComponentDetails.cpp
Outdated
Show resolved
Hide resolved
VitruvioHost/Plugins/Vitruvio/Source/VitruvioEditor/Private/VitruvioComponentDetails.cpp
Outdated
Show resolved
Hide resolved
VitruvioHost/Plugins/Vitruvio/Source/VitruvioEditor/Private/VitruvioComponentDetails.cpp
Outdated
Show resolved
Hide resolved
VitruvioHost/Plugins/Vitruvio/Source/VitruvioEditor/Private/VitruvioComponentDetails.cpp
Outdated
Show resolved
Hide resolved
VitruvioHost/Plugins/Vitruvio/Source/VitruvioEditor/Private/VitruvioComponentDetails.cpp
Outdated
Show resolved
Hide resolved
VitruvioHost/Plugins/Vitruvio/Source/VitruvioEditor/Public/VitruvioComponentDetails.h
Outdated
Show resolved
Hide resolved
Added capability to edit multiple Vitruvio Components simultaneously Fix tabs
sidmenon97
force-pushed
the
smenon/edit_multiple_shapes
branch
from
7afd1d0
to
120bb00
Compare
Added generic SetAttribute function to VitruvioComponent * Added generic SetAttribute function to VitruvioComponent and updated SetAttributes() to use the new SetAttrbiute function. * Also, some additional variable renaming changes.
sidmenon97
force-pushed
the
smenon/edit_multiple_shapes
branch
from
e7225e8
to
e06ee16
Compare
bneukom
force-pushed
the
smenon/edit_multiple_shapes
branch
from
0eb5d5e
to
e06ee16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.