Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiphase Hybrid - FY24 Q2 milestone (sharpening the pressure field) #1099

Open
wants to merge 46 commits into
base: main
Choose a base branch
from
Open

Multiphase Hybrid - FY24 Q2 milestone (sharpening the pressure field) #1099

wants to merge 46 commits into from

Conversation

mbkuhn
Copy link
Contributor

@mbkuhn mbkuhn commented Jun 11, 2024 •
edited
Loading

Summary

This PR enables the pressure field from Nalu-Wind to be modified according to the sharpening of the interface via terms applied to the pressure gradient.

Pull request type

Please check the type of change introduced:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

The following is included:

  • new unit-test(s)
  • new regression test(s)
  • documentation for new capability

This PR was tested by running:

  • the unit tests
    • on GPU
    • on CPU
  • the regression tests
    • on GPU
    • on CPU

Additional background

This should be accompanied with new unit tests; the reg tests will be in the exawind-driver repo. More checking and refinement to come; I wanted to put it out there. To follow the merging of #1065

mbkuhn and others added 30 commits May 17, 2024 09:25
@mbkuhn
compiles; a couple things still need to be added
f7005d2
@mbkuhn
prescribed velocity simulations should not need special treatment
3324a73
@mbkuhn
provide options for decoupling projections in overset
6cc387b
@mbkuhn
formatting
98f417a
@mbkuhn
CI
dcd5e36
@mbkuhn
testing neumann vof normal calc
998a91e
@mbkuhn
unit test for alpha flux
d0bba36
@mbkuhn
generalize to test every direction
f8685c0
@mbkuhn
velocity_face unit test
8baac51
@mbkuhn
verbosity for output on each sharpen step
f5bad9e
@mbkuhn
Merge branch 'main' into mphase_hybrid_overset_ops1
8efaee9
@mbkuhn
multiple changes from regression testing
1486fe9 
* typo in parser argument
* simplify hydrostatic ops
* fill internal iblank ghost cells
* initialize pressure for sloshing tank case
@mbkuhn
make hydrostatic_ops unit test harder to pass (fails with old impleme…
e18c0b7 
…ntation)

* remove unintended changes too
@mbkuhn
verbosity output tweaks
a78a35c
@mbkuhn
Merge branch 'main' into mphase_hybrid_overset_ops1
9f05c8d
@mbkuhn
first set of review edits
8ebe11e
@mbkuhn
correcting logic
9210f29
@mbkuhn
verbose names, remove comments
34a8b66
@mbkuhn
const
d489027
@mbkuhn
remove unnecessary intermediate variables
429d268
@mbkuhn
better ibdy code
21c865f
@mbkuhn
fd = finite_difference
84182bd
@mbkuhn
fix weird alpha logic in levelset2vof
7cc5799
@mbkuhn
mm1, mm2 declarations
c8fe66d
@mbkuhn
some IntVect stuff
81e7914
@mbkuhn
correct IntVect declaration
dee3540
@mbkuhn
run_algorithm tweaks
aa332f9
@mbkuhn
remove wrong comments
e7805c8
@mbkuhn
IntVect tweaks
ba313a0
@mbkuhn
initialize things that come from elsewhere with quiet_NaN
de635d4
@mbkuhn mbkuhn force-pushed the mphase_hybrid_overset_ops2 branch from 453ec3c to 1771c5d Compare July 10, 2024 15:02
@mbkuhn mbkuhn marked this pull request as ready for review July 18, 2024 21:37
@mbkuhn mbkuhn requested a review from marchdf July 18, 2024 22:05
marchdf
marchdf requested changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@marchdf marchdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!! Just some minor stuff.

amr-wind/overset/OversetOps.cpp Outdated Show resolved Hide resolved
amr-wind/overset/OversetOps.cpp Outdated Show resolved Hide resolved
amr-wind/overset/OversetOps.cpp Outdated Show resolved Hide resolved
amr-wind/overset/overset_ops_K.H Outdated Show resolved Hide resolved
amr-wind/overset/overset_ops_K.H Outdated Show resolved Hide resolved
amr-wind/overset/overset_ops_routines.cpp Show resolved Hide resolved
amr-wind/overset/overset_ops_routines.cpp Outdated Show resolved Hide resolved
amr-wind/overset/overset_ops_routines.cpp Outdated Show resolved Hide resolved
amr-wind/overset/overset_ops_routines.cpp Outdated Show resolved Hide resolved
unit_tests/multiphase/test_vof_overset_ops.cpp Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marchdf marchdf marchdf requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mbkuhn @marchdf