Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable multiple IB boxes to be defined #1120

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

marchdf
Copy link
Contributor

@marchdf marchdf commented Jul 8, 2024

Summary

Enable multiple IB boxes to be defined.

Pull request type

Please check the type of change introduced:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

This PR was tested by running:

  • the unit tests
    • on GPU
    • on CPU
  • the regression tests
    • on GPU
    • on CPU

Additional background

Two boxes!

Screenshot 2024-07-08 at 10 54 11 AM

Closes: #1117

@marchdf marchdf requested review from gdeskos and mbkuhn July 8, 2024 17:02
@marchdf marchdf marked this pull request as ready for review July 8, 2024 19:11
@marchdf marchdf enabled auto-merge (squash) July 8, 2024 19:54
@marchdf marchdf force-pushed the enable-multi-ib-box branch 4 times, most recently from 9d221aa to 0cf555f Compare July 9, 2024 14:49
@marchdf marchdf merged commit 084db33 into Exawind:main Jul 9, 2024
13 checks passed
@marchdf marchdf deleted the enable-multi-ib-box branch July 9, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to represent more than one Box type with the Immersed Boundary method
2 participants