Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update amrex submodule #1121

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Update amrex submodule #1121

merged 1 commit into from
Jul 8, 2024

Conversation

marchdf
Copy link
Contributor

@marchdf marchdf commented Jul 8, 2024

Summary

Update the amrex submodule. Something changed here: AMReX-Codes/amrex#4020 because of AMReX-Combustion/PeleLMeX#396. I checked and the issue that created the first fix to AMReX is still fixed with this.

Pull request type

Please check the type of change introduced:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe): submodule update

Checklist

This PR was tested by running:

  • the unit tests
    • on GPU
    • on CPU
  • the regression tests
    • on GPU
    • on CPU

Closes: #1119

@marchdf marchdf marked this pull request as ready for review July 8, 2024 19:10
@marchdf marchdf requested review from jrood-nrel and mbkuhn July 8, 2024 19:10
@marchdf marchdf enabled auto-merge (squash) July 8, 2024 19:54
Copy link
Contributor

@mbkuhn mbkuhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking at the conversation on the AMReX and Pele pages, this looks good to me!

@marchdf marchdf merged commit c0f89af into Exawind:main Jul 8, 2024
13 checks passed
@marchdf marchdf deleted the update-submods branch July 8, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants