F/rayleigh damping #726
Draft
F/rayleigh damping #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inline nalu-wind.
…aceFluxBCElemKernel.
…u with wall shear stress fluctuations of Moeng or Schumann or completely local.
…teration; fix for the fluctuating surface temperature flux component to deal properly with zero divided by zero sitations.
… calculating fluctuating flux.
…in the unit test.
Co-authored-by: Shreyas Ananthan <[email protected]>
Co-authored-by: Shreyas Ananthan <[email protected]>
Co-authored-by: Shreyas Ananthan <[email protected]>
Co-authored-by: Shreyas Ananthan <[email protected]>
Co-authored-by: Shreyas Ananthan <[email protected]>
Co-authored-by: Shreyas Ananthan <[email protected]>
…nd having just a single function that can operate in both alg 1 and 2 modes.
Co-authored-by: Shreyas Ananthan <[email protected]>
Co-authored-by: Shreyas Ananthan <[email protected]>
Co-authored-by: Shreyas Ananthan <[email protected]>
Co-authored-by: Shreyas Ananthan <[email protected]>
…sampling a parameter that can be modified in the code.
…ch is up to date with exawind/master.
…lux BC code and nalu-wind master.
…stead of hard coding.
sayerhs
reviewed
Oct 18, 2020
| @@ -26,7 +26,7 @@ class EquationSystems; | |||
| class WallDistEquationSystem : public EquationSystem | |||
| { | |||
| public: | |||
| WallDistEquationSystem(EquationSystems&); | |||
| WallDistEquationSystem(EquationSystems&, std::string = ""); | |||
There was a problem hiding this comment.
Was this tested against SST? Looking at the code for default blade-resolved simulations, this will change the ndtw field to minimum_distance_to_ and RANS models are expecting the field minimum_distance_to_wall. This will break all existing restart files.
Suggested change
| WallDistEquationSystem(EquationSystems&, std::string = ""); | |
| WallDistEquationSystem(EquationSystems&, std::string = "wall", bool addToEqSys = true); |
Comment on lines
+108
to
+112
| EquationSystems& eqSystems, std::string wallname) | ||
| : EquationSystem(eqSystems, "WallDistEQS" + wallname, "ndtw"), | ||
| nodalGradAlgDriver_(realm_, dphidx_name(wallname)), | ||
| managePNG_(realm_.get_consistent_mass_matrix_png("ndtw")), | ||
| wallName_(wallname) |
There was a problem hiding this comment.
Suggested change
| EquationSystems& eqSystems, std::string wallname) | |
| : EquationSystem(eqSystems, "WallDistEQS" + wallname, "ndtw"), | |
| nodalGradAlgDriver_(realm_, dphidx_name(wallname)), | |
| managePNG_(realm_.get_consistent_mass_matrix_png("ndtw")), | |
| wallName_(wallname) | |
| EquationSystems& eqSystems, std::string wallname, bool addToEqsys) | |
| : EquationSystem(eqSystems, "WallDistEQS" + wallname, "ndtw"), | |
| nodalGradAlgDriver_(realm_, dphidx_name(wallname)), | |
| managePNG_(realm_.get_consistent_mass_matrix_png("ndtw")), | |
| wallName_(wallname) |
Comment on lines
+126
to
+128
| if (wallname == "") { | ||
| realm_.push_equation_to_systems(this); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (wallname == "") { | |
| realm_.push_equation_to_systems(this); | |
| } | |
| if (addToEqSys) { | |
| realm_.push_equation_to_systems(this); | |
| } |
|
@mchurchf can you resubmit this pull-request with only Rayleigh damping code on top of the latest main branch? |
rcknaus
reviewed
Oct 27, 2020
| cell_damping_force[d] = | ||
| c * volume_.get(node, 0) * (params_.uref[d] - velocity_.get(node, d)); | ||
| } | ||
| // derivstive of cell damping wrt u_j |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull-request type:
Description of the pull-request
This pull request provides basic Rayleigh damping capability for attenuating atmospheric gravity waves at domain boundaries other than the ground. The implementation is by Robert Knaus at Sandia. Matt Churchfield integrated Robert's implementation into the current exawind/nalu-wind/master and the upgraded lower ABL bc codes and performed testing.