Extract XMP data from embedded JPEG preview inside RAF files

[cytrinox]

The Fujifilm X-T5 camera stores in-camera rating for RAF images by using XMP. But the XMP data is not directly encoded into the RAF structure - instead it is attached as a second APP1 segment to the embedded JPEG preview file.

This patch extracts the JPEG preview and parses it like a standalone JPEG file.

fixes #2610

[cytrinox]

To verify #2610 one can use:

exiv2 --Print IkytEX ../_DSF0052.RAF

The XMP rating is now printed:

Xmp.xmp.Rating                               XmpText    4

[cytrinox]

@kmilos Here we go. Maybe you can have a look at it - I've touched C++ code long time ago 😄

There is one thing that could be improved: The JpegImage metadata parser already parses exif and other information. There is no need to keep the old direct method by using TiffParser. But I don't know how the get the byte order for setByteOrder(bo);.

[ghost]

👇 Click on the image for a new way to code review

Legend

[kmilos]

Ah, probably want to wrap the whole JPEG parsing (incl. the two preview tags) in a try-catch now, or update the expected test output...

[codecov]

Codecov Report

Merging #2613 (c493e38) into main (c86ae6a) will decrease coverage by 0.01%.
The diff coverage is 35.71%.

@@            Coverage Diff             @@
##             main    #2613      +/-   ##
==========================================
- Coverage   63.92%   63.92%   -0.01%     
==========================================
  Files         103      103              
  Lines       22309    22306       -3     
  Branches    10795    10796       +1     
==========================================
- Hits        14262    14259       -3     
- Misses       5825     5827       +2     
+ Partials     2222     2220       -2     

Impacted Files	Coverage Δ
src/rafimage.cpp	20.29% <35.71%> (-0.84%)	⬇️

... and 4 files with indirect coverage changes

[cytrinox]

Ah, probably want to wrap the whole JPEG parsing (incl. the two preview tags) in a try-catch now, or update the expected test output...

fixed.

[kmilos]

Almost there! 👍

[kmilos]

@Mergifyio backport 0.28.x

[mergify]

backport 0.28.x

✅ Backports have been created

• #2632 Extract XMP data from embedded JPEG preview inside RAF files (backport #2613) has been created for branch 0.28.x