Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove exiv2-xmp from CMake and pkg-config files #2619

Merged
merged 4 commits into from
May 16, 2023
Merged

Remove exiv2-xmp from CMake and pkg-config files #2619

merged 4 commits into from
May 16, 2023

Conversation

kmilos
Copy link
Collaborator

@kmilos kmilos commented May 16, 2023 •
edited
Loading

Resolves #2618

@kmilos kmilos requested a review from piponazo May 16, 2023 07:17
@ghost
Copy link

ghost commented May 16, 2023 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@kmilos kmilos added bug CMake Configuration issues related with CMake labels May 16, 2023
@codecov
Copy link

codecov bot commented May 16, 2023 •
edited
Loading

Codecov Report

Merging #2619 (250c081) into main (c319699) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2619   +/-   ##
=======================================
  Coverage   63.93%   63.93%           
=======================================
  Files         103      103           
  Lines       22296    22298    +2     
  Branches    10787    10789    +2     
=======================================
+ Hits        14255    14257    +2     
  Misses       5823     5823           
  Partials     2218     2218
Impacted Files Coverage Δ
src/bmffimage.cpp 72.67% <100.00%> (+0.11%) ⬆️

@kmilos kmilos changed the title Remove exiv2-xmp from pkg-config file Remove exiv2-xmp from CMake and pkg-config files May 16, 2023
@neheb
Copy link
Collaborator

neheb commented May 16, 2023

I assume this is not an issue with meson. I don't remember code like this.

@kmilos
Copy link
Collaborator Author

kmilos commented May 16, 2023

I assume this is not an issue with meson. I don't remember code like this.

Indeed, it looks like you've been using it as an internal object from day one with Meson.

@neheb neheb merged commit ec6c806 into main May 16, 2023
112 checks passed
@neheb neheb deleted the kmilos/rm_exiv2-xmp branch May 16, 2023 17:32
@kmilos
Copy link
Collaborator Author

kmilos commented May 16, 2023

@Mergifyio backport 0.28.x

@mergify
Copy link
Contributor

mergify bot commented May 16, 2023 •
edited
Loading

backport 0.28.x

✅ Backports have been created

@mergify mergify bot mentioned this pull request May 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neheb neheb neheb approved these changes

@piponazo piponazo Awaiting requested review from piponazo

Assignees
No one assigned
Labels
bug CMake Configuration issues related with CMake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Installed CMake and pkg-config files still link to exiv2-xmp
2 participants
@kmilos @neheb