Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add macOS arm64 job to basic workflow #2910

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Conversation

kmilos
Copy link
Collaborator

@kmilos kmilos commented Feb 2, 2024

No description provided.

@kmilos kmilos requested review from piponazo and neheb February 2, 2024 10:18
@ghost
Copy link

ghost commented Feb 2, 2024

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c8d1192) 63.93% compared to head (9466b4c) 63.93%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2910   +/-   ##
=======================================
  Coverage   63.93%   63.93%           
=======================================
  Files         104      104           
  Lines       22400    22400           
  Branches    10877    10877           
=======================================
  Hits        14322    14322           
  Misses       5854     5854           
  Partials     2224     2224           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

neheb
neheb previously approved these changes Feb 2, 2024
@mergify mergify bot dismissed neheb’s stale review February 2, 2024 10:44

Pull request has been modified.

@kmilos
Copy link
Collaborator Author

kmilos commented Feb 2, 2024

Hm, Conan is not picking up system brotli on Ubuntu for some reason (the version is 1.0.9), but I guess it's not a big deal...

@kmilos kmilos requested a review from neheb February 2, 2024 10:57
@kmilos kmilos force-pushed the kmilos/ci_basic_mac_arm64 branch 4 times, most recently from df5b924 to 2a9af8e Compare February 2, 2024 13:18
@neheb neheb merged commit 36e3d55 into main Feb 6, 2024
65 checks passed
@neheb neheb deleted the kmilos/ci_basic_mac_arm64 branch February 6, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants