Added compiler option -fPIC. Required for clang+static linking with libexiv2 #2970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neheb
reviewed
May 20, 2024
| @@ -67,6 +67,7 @@ option(EXIV2_TEAM_OSS_FUZZ "Build config for OSS-Fuzz" OFF) | |||
|
|
|||
| option(EXIV2_TEAM_PACKAGING "Additional stuff for generating packages" OFF) | |||
| set(EXTRA_COMPILE_FLAGS " ") | |||
| add_compile_options( "-fPIC" ) | |||
There was a problem hiding this comment.
CMAKE_POSITION_INDEPENDENT_CODE
|
This is holdout behavior from Autotools where by default, shared libraries are compiled as PIC but static ones are not. CMake mimics that. meson is PIC everywhere by default for speed reasons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using clang++ (18.0.0, 19.0.0) I cannot not link my application against the static exiv2 library libexiv2.a. The linker complaines about missing a -fPIC (or -fPIE) flag.
Adding this flag solves the issue.
This linking error does not occur when g++ is used. It also does not occur when the .so library is used. Not for g++ and not for clang++. However, still adding the -fPIC flag doesn't hurt in those cases.
So strictly speaking, the fix is required for at least clang++ and static exiv2. The fix provided does not take this into account, and simply applies the flag regardless.