Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix libcurl linkage on Windows #2983

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Fix libcurl linkage on Windows #2983

merged 1 commit into from
Jun 10, 2024

Conversation

kmilos
Copy link
Collaborator

@kmilos kmilos commented Jun 10, 2024 •
edited
Loading

See msys2/MINGW-packages#21028

No idea about the MSVC + Conan stuff though - looks like GitHub removed a whole bunch of MSVC toolchains from their runners recently?

@kmilos kmilos requested a review from neheb June 10, 2024 14:28
@kmilos kmilos added CMake Configuration issues related with CMake windows Windows Specific issues build labels Jun 10, 2024
@kmilos kmilos merged commit abaffbc into main Jun 10, 2024
52 of 63 checks passed
@mergify mergify bot deleted the kmilos/fix_curl_link branch June 10, 2024 15:37
@kmilos
Copy link
Collaborator Author

kmilos commented Jun 10, 2024

@mergify backport 0.28.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 10, 2024 •
edited
Loading

backport 0.28.x

✅ Backports have been created

@mergify mergify bot mentioned this pull request Jun 10, 2024
Merged
@kevinbackhouse kevinbackhouse mentioned this pull request Jul 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neheb neheb neheb approved these changes

Assignees
No one assigned
Labels
build CMake Configuration issues related with CMake windows Windows Specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kmilos @neheb