Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use readOrThrow() to detect premature EOF #3005

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

kevinbackhouse
Copy link
Collaborator

Fixes an out-of-bounds read found by OSS-Fuzz. The bug looks pretty harmless to me, but I'll request a CVE and I think we should backport the fix to 0.28.x.

@kevinbackhouse kevinbackhouse added bug OSS-Fuzz Bug reported by https://google.github.io/oss-fuzz/ labels Jul 3, 2024
@kevinbackhouse kevinbackhouse force-pushed the asfvideo-readOrThrow branch 2 times, most recently from 04d5eee to 6630755 Compare July 3, 2024 23:02
@kevinbackhouse
Copy link
Collaborator Author

https://github.com/Mergifyio backport 0.28.x

Copy link
Contributor

mergify bot commented Jul 3, 2024

backport 0.28.x

✅ Backports have been created

@kevinbackhouse kevinbackhouse merged commit 35a6b8f into Exiv2:main Jul 4, 2024
57 of 58 checks passed
@kevinbackhouse
Copy link
Collaborator Author

I've opened a draft advisory to request a CVE: https://github.com/Exiv2/exiv2/security/advisories/GHSA-38rv-8x93-pvrh

@kevinbackhouse
Copy link
Collaborator Author

This is the poc file: issue-3005.asf.gz
It only causes a crash with specific sanitizer options enabled. My ASAN build wasn't able to detect the problem, but I verified the out-of-bounds read reported by OSS-Fuzz by manually stepping through the code in gdb.

@kevinbackhouse kevinbackhouse deleted the asfvideo-readOrThrow branch July 4, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug OSS-Fuzz Bug reported by https://google.github.io/oss-fuzz/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants