FFWEB-2096: Add reverse proxy support #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-laurowski
suggested changes
Jul 27, 2021
| $this->_sTemplate = $sForceTemplate; | ||
| } | ||
|
|
||
| return $this->_sTemplate; |
There was a problem hiding this comment.
_sTemplate is not defined in any of parent class so it has to be defined in this class
- do not use
_for property names - better not use this convention
sForceTemplate. where the first letter of variable indicates the type. I know its widely used in Oxid code base but not in the module.
a-laurowski
force-pushed
the
master
branch
2 times, most recently
from
8b10194
to
84938a0
Compare
grzegorz-jamroz
force-pushed
the
master
branch
from
799f05a
to
aefa254
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FFWEB-2096
Add compatibility with Reverse Proxy
6.2.4 CE
7.4