Skip to content

Commit

Permalink
Some linting.
Browse files Browse the repository at this point in the history
  • Loading branch information
knirirr committed Jul 30, 2024
1 parent 81cb466 commit 45bae04
Show file tree
Hide file tree
Showing 4 changed files with 115 additions and 113 deletions.
19 changes: 11 additions & 8 deletions src/App.vue
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
<template>
<v-app id="app">
<div class="d-flex appWrapper fill-height flex-column justify-space-between">
<div
class="d-flex appWrapper fill-height flex-column justify-space-between"
>
<router-view />
<Footer />
</div>
Expand All @@ -10,19 +12,19 @@
<script>
import Footer from "@/components/Others/Footer.vue";
export default {
name: 'App',
components:{Footer},
name: "App",
components: { Footer },

Check warning on line 16 in src/App.vue

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

src/App.vue#L16

Name "Footer" is reserved in HTML.
data() {
return {
loading:true,
}
loading: true,
};
},
/* istanbul ignore next */
async updated() {
// very important line of code which prevents layout shifting which is considered as one negative point for SEO
await this.$nextTick()
await this.$nextTick();
this.loading = false;
}
},
};
</script>

Expand All @@ -33,7 +35,8 @@ export default {
min-height: 99vh;
}
html, body {
html,
body {
height: 100%;
}
Expand Down
9 changes: 6 additions & 3 deletions src/components/Navigation/Jumbotron.vue
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,12 @@
// This goes in the h1 above, should it be needed again.
-->
{{ getJumbotronData["title"] }}
<em v-if="getJumbotronData['tempSubTitle']" class="green--text">{{
getJumbotronData["tempSubTitle"]
}}</em>
<em
v-if="getJumbotronData['tempSubTitle']"
class="green--text"
>
{{ getJumbotronData["tempSubTitle"] }}
</em>
</h1>

<h2
Expand Down
Loading

0 comments on commit 45bae04

Please sign in to comment.