Add namespace keyword for using directive and modify style guide check.

FIWARE · Apr 14, 2024 · 9e5d962 · 9e5d962
1 parent f7cf9f0
commit 9e5d962
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 8 deletions.
diff --git a/scripts/style_check.sh b/scripts/style_check.sh
@@ -228,7 +228,7 @@ sev[8]=MAYOR;  cat[8]='#endif line should be'
 sev[9]=MAYOR;  cat[9]='Weird number of spaces at line-start'
 sev[10]=MAYOR; cat[10]='Blank line at the end of a code block'
 sev[11]=MAYOR; cat[11]='Include the directory when naming'
-sev[12]=MAYOR; cat[12]='Do not use namespace using-directives'
+sev[12]=MINOR; cat[12]='Do not use namespace using-directives'
 sev[13]=MAYOR; cat[13]='Is this a non-const reference'
 sev[14]=MAYOR; cat[14]='At least two spaces is best between code and comments'
 sev[15]=MAYOR; cat[15]='Labels should always be indented at least one space'

diff --git a/src/lib/orionld/dds/NgsildPublisher.h b/src/lib/orionld/dds/NgsildPublisher.h
@@ -61,7 +61,7 @@ extern "C"
 #include "orionld/dds/NgsildEntityPubSubTypes.h"
 #include "orionld/dds/NgsildEntity.h"
 
-using eprosima::fastdds::dds;
+using namespace eprosima::fastdds::dds;
 
 
 

diff --git a/src/lib/orionld/dds/NgsildSubscriber.h b/src/lib/orionld/dds/NgsildSubscriber.h
@@ -61,7 +61,7 @@ extern "C"
 
 #include "orionld/common/traceLevels.h"                     // Trace Levels
 
-using eprosima::fastdds::dds;
+using namespace eprosima::fastdds::dds;
 
 
 

diff --git a/src/lib/orionld/dds/ddsPublish.cpp b/src/lib/orionld/dds/ddsPublish.cpp
@@ -32,7 +32,7 @@ extern "C"
 #include "orionld/dds/NgsildEntity.h"
 #include "orionld/dds/NgsildPublisher.h"
 
-using eprosima::fastdds::dds;
+using namespace eprosima::fastdds::dds;
 
 
 

diff --git a/src/lib/orionld/dds/ddsSubscribe.cpp b/src/lib/orionld/dds/ddsSubscribe.cpp
@@ -40,7 +40,7 @@ extern "C"
 //
 void ddsSubscribe(const char* topicType, const char* topicName)
 {
-  KT_V("Creating a subscription on '%s/%s'"m topicType, topicName);
+  KT_V("Creating a subscription on '%s/%s'", topicType, topicName);
 
   NgsildSubscriber* subP = new NgsildSubscriber();
 
@@ -49,6 +49,6 @@ void ddsSubscribe(const char* topicType, const char* topicName)
     subP->run(1400000);  // EPROS: one single subscriber ... run forever ...
   }
 
-  KT_V("Deleting the subscription on '%s/%s'"m topicType, topicName);
+  KT_V("Deleting the subscription on '%s/%s'", topicType, topicName);
   delete subP;
-}
+} 
diff --git a/test/functionalTest/ftClient/ftClient.cpp b/test/functionalTest/ftClient/ftClient.cpp
@@ -61,7 +61,7 @@ extern "C"
 
 
 
-using eprosima::fastdds::dds;
+using namespace eprosima::fastdds::dds;