Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test rebuilding base image #1528

Merged
merged 9 commits into from
Jan 11, 2024
Merged

test rebuilding base image #1528

merged 9 commits into from
Jan 11, 2024

Conversation

pulledtim
Copy link

Check if rebuilding the base image with new import of keys is enough for fixing the build

Copy link

github-actions bot commented Jan 10, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️

@pulledtim
Copy link
Author

pulledtim commented Jan 11, 2024

Rebuilding the base image was not easily possible due to the need of updating different libraries and running into conflicts. The current workaround re-adds the repository with the new gpg public key but only in the test image. This is only a hacky workaround and should be removed once the baseimage is rebuild successfully!

@pulledtim pulledtim self-assigned this Jan 11, 2024
@pulledtim pulledtim marked this pull request as ready for review January 11, 2024 07:59
Copy link
Collaborator

@kzangeli kzangeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!!

LGTM

Just, let me try to fix the failing functests.

@kzangeli kzangeli merged commit fa10853 into develop Jan 11, 2024
9 of 11 checks passed
@kzangeli kzangeli deleted the outdated-repo-keys branch January 11, 2024 10:19
@github-actions github-actions bot locked and limited conversation to collaborators Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants