Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure docker #1622

Merged
merged 5 commits into from
Jun 5, 2024
Merged

Restructure docker #1622

merged 5 commits into from
Jun 5, 2024

Conversation

jicarretero
Copy link
Collaborator

@jicarretero jicarretero commented Jun 5, 2024

Proposed changes

The creation of Dockerfiles (base and the final one) has been rewriten. In the first case (base Docker image), things have been refactored and rewriten in a more appropriate way. In the second one (Orion-ld docker image) things have been better copied in order to produce a much smaller docker image

Types of changes

What types of changes does your code introduce to the project: Put an x in the boxes that apply

  • [ X] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • [ X] I have read the CONTRIBUTING doc
  • [ X] I have signed the CLA
  • [ X] I have added tests that prove my fix is effective or that my feature works
  • [ X] I have added necessary documentation (if appropriate)
  • [ X] Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...

Copy link

github-actions bot commented Jun 5, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️

@jicarretero
Copy link
Collaborator Author

I have read the CLA Document and I hereby sign the CLA

@kzangeli
Copy link
Collaborator

kzangeli commented Jun 5, 2024

Never mind the errors with Mintaka.
It doesn't work, never really did: it uses to fail like once every three attempts.
Lately it's more like it falis three times every three attempts ... :(

@kzangeli
Copy link
Collaborator

kzangeli commented Jun 5, 2024

One error in the functests. It's a known error, on "expiresAt" set to June 1 2024 (a few days ago).
It's really not an error and I have fixed it already.
Merging

@kzangeli kzangeli merged commit ed93d66 into develop Jun 5, 2024
9 of 11 checks passed
@kzangeli kzangeli deleted the restructure-docker branch June 5, 2024 13:57
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants