This repository has been archived by the owner on Oct 6, 2022. It is now read-only.
Check for lightdm in window and if languages is an object #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francoiscote
suggested changes
Jun 3, 2017
src/index.js
Outdated
| @@ -8,7 +8,7 @@ import injectTapEventPlugin from 'react-tap-event-plugin'; | |||
| injectTapEventPlugin(); | |||
|
|
|||
| // Load mock if in development mode | |||
| if (!lightdm && process.env.NODE_ENV === 'development') { | |||
| if (!(lightdm in window) && process.env.NODE_ENV === 'development') { | |||
There was a problem hiding this comment.
lightdm should be a string here. !("lightdm" in window)
src/index.js
Outdated
| @@ -46,15 +46,15 @@ if (!lightdm && process.env.NODE_ENV === 'development') { | |||
| } | |||
| } | |||
|
|
|||
| if (!lightdm || !lightdm.languages) { | |||
| if (!(lightdm in window) || !(typeof lightdm.languages === "object")) { | |||
src/index.js
Outdated
| const timeout = setTimeout(() => { | ||
| clearInterval(interval); | ||
| document.body.innerHTML += '<h1 style="background-color: white; color: red;">Lightdm did not load</h1>'; | ||
| throw new Error('lightdm did not load in time'); | ||
| }, 1000); | ||
| const interval = setInterval(() => { | ||
|
|
||
| if (lightdm && lightdm.languages) { | ||
| if (lightdm in window && typeof lightdm.languages === "object") { |
Thanks francoiscote
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #2