Skip to content
This repository has been archived by the owner on Feb 19, 2022. It is now read-only.

Enhancement: Add finalize effect, triggered on unmount (symmetry with initialize) #107

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

agurtovoy
Copy link
Contributor

@agurtovoy agurtovoy commented Aug 21, 2018


The maintainers of this repo require that all pull request submitters adhere to the following:

  • I have read and will comply with the contribution guidelines.
    (required)
  • I have read and will comply with the code of conduct.
    (required)
  • All related documentation has been updated to reflect the changes made. (required)
  • My commit messages are cleaned up and ready to merge. (required)

The maintainers of this repository require you to select the semantic version type that
the changes in this pull request represent. Please select one of the following:

  • major
  • minor
  • patch
  • documentation only

@maintainerd
Copy link

maintainerd bot commented Aug 21, 2018

maintainerd logging is enabled for this repository.

All actions related to rules and their enforcement will be logged here as a permanent record.


Click to view log...

  • 2018-08-21T23:33:31.882Z:b85b485: The pull request was created
  • 2018-08-21T23:35:44.458Z:b85b485: @agurtovoy checked I have read and will comply with the [contribution guidelines](https://github.com/FormidableLabs/freactal/blob/master/CONTRIBUTE.md)..
  • 2018-08-21T23:35:48.316Z:b85b485: @agurtovoy checked All related documentation has been updated to reflect the changes made. _(required)_.
  • 2018-08-21T23:36:22.003Z:b85b485: @agurtovoy checked I have read and will comply with the [code of conduct](https://github.com/FormidableLabs/freactal/blob/master/CONTRIBUTE.md)..
  • 2018-08-21T23:43:59.494Z:b85b485: @agurtovoy selected minor as the semantic version.
  • 2018-08-21T23:44:02.777Z:b85b485: @agurtovoy checked My commit messages are cleaned up and ready to merge. _(required)_.

@agurtovoy
Copy link
Contributor Author

Not sure why maintainerd is complaining about cc4ba78; it does have an empty second line. Maybe an old version of maintainerd (divmain/maintainerd#1?)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant