Add backup deployment pod label

FoundationDB · Jul 7, 2023 · 85a7d7f · 85a7d7f
1 parent 2e5847b
commit 85a7d7f
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/api/v1beta2/foundationdb_labels.go b/api/v1beta2/foundationdb_labels.go
@@ -37,6 +37,9 @@ const (
 	// deployments to a cluster.
 	BackupDeploymentLabel = "foundationdb.org/backup-for"
 
+	// BackupDeploymentPodLabel provides the label to select Pods for a specific Backup deployment.
+	BackupDeploymentPodLabel = "foundationdb.org/deployment-name"
+
 	// PublicIPSourceAnnotation is an annotation key that specifies where a pod
 	// gets its public IP from.
 	PublicIPSourceAnnotation = "foundationdb.org/public-ip-source"

diff --git a/internal/pod_models.go b/internal/pod_models.go
@@ -942,9 +942,9 @@ func GetBackupDeployment(backup *fdbv1beta2.FoundationDBBackup) (*appsv1.Deploym
 	if podTemplate.ObjectMeta.Labels == nil {
 		podTemplate.ObjectMeta.Labels = make(map[string]string, 1)
 	}
-	podTemplate.ObjectMeta.Labels["foundationdb.org/deployment-name"] = deployment.ObjectMeta.Name
+	podTemplate.ObjectMeta.Labels[fdbv1beta2.BackupDeploymentPodLabel] = deployment.ObjectMeta.Name
 	deployment.Spec.Selector = &metav1.LabelSelector{MatchLabels: map[string]string{
-		"foundationdb.org/deployment-name": deployment.ObjectMeta.Name,
+		fdbv1beta2.BackupDeploymentPodLabel: deployment.ObjectMeta.Name,
 	}}
 
 	podTemplate.Spec.Volumes = append(podTemplate.Spec.Volumes,

diff --git a/internal/pod_models_test.go b/internal/pod_models_test.go
@@ -2899,7 +2899,7 @@ var _ = Describe("pod_models", func() {
 				Expect(len(deployment.ObjectMeta.OwnerReferences)).To(Equal(1))
 				Expect(deployment.ObjectMeta.OwnerReferences[0].UID).To(Equal(cluster.ObjectMeta.UID))
 				Expect(deployment.ObjectMeta.Labels).To(Equal(map[string]string{
-					"foundationdb.org/backup-for": string(cluster.ObjectMeta.UID),
+					fdbv1beta2.BackupDeploymentLabel: string(cluster.ObjectMeta.UID),
 				}))
 				Expect(deployment.ObjectMeta.Annotations).To(Equal(map[string]string{
 					"foundationdb.org/last-applied-spec": "a1d6ee086624f097243eb14aefbedf84a9016ba0f85640f11020bf50ec9e6d9b",
@@ -2913,10 +2913,10 @@ var _ = Describe("pod_models", func() {
 
 			It("should set the labels for the pod selector", func() {
 				Expect(*deployment.Spec.Selector).To(Equal(metav1.LabelSelector{MatchLabels: map[string]string{
-					"foundationdb.org/deployment-name": "operator-test-1-backup-agents",
+					fdbv1beta2.BackupDeploymentPodLabel: "operator-test-1-backup-agents",
 				}}))
 				Expect(deployment.Spec.Template.ObjectMeta.Labels).To(Equal(map[string]string{
-					"foundationdb.org/deployment-name": "operator-test-1-backup-agents",
+					fdbv1beta2.BackupDeploymentPodLabel: "operator-test-1-backup-agents",
 				}))
 			})