Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get removal mode #1751

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Conversation

johscheuer
Copy link
Member

@johscheuer johscheuer commented Jul 20, 2023

Description

Before the GetRemovalMode was returning the wrong value.

Fixes: #1750

Type of change

Please select one of the options below.

  • Bug fix (non-breaking change which fixes an issue)

Discussion

Testing

Added unit tests for the method.

Documentation

Follow-up

@johscheuer johscheuer added the bug Something isn't working label Jul 20, 2023
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: b9562e0
  • Duration 3:05:35
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer closed this Jul 20, 2023
@johscheuer johscheuer reopened this Jul 20, 2023
@johscheuer
Copy link
Member Author

Summarizing 1 Failure:
  [FAIL] Operator HA Upgrades upgrading a cluster when no remote processes are restarted [It] Upgrade from 6.3.25 to 7.1.31 when no remote processes are restarted [e2e, pr]
  /codebuild/output/src3815948778/src/github.com/FoundationDB/fdb-kubernetes-operator/e2e/test_operator_ha_upgrades/operator_ha_upgrade_test.go:569

The test failure is one that we have to debug, this test is known to be flaky

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: b9562e0
  • Duration 2:28:38
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer merged commit e8abd80 into FoundationDB:main Jul 25, 2023
16 checks passed
@johscheuer johscheuer deleted the fix-get-removal-mode branch July 25, 2023 08:33
johscheuer added a commit to johscheuer/fdb-kubernetes-operator that referenced this pull request Aug 2, 2023
* Fix the GetRemovalMode method to return the correct value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeletionMode and PodUpdate should be differentiated
3 participants