Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Readme to include Cocoapod installation #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andynovak12
Copy link
Contributor

No description provided.

Copy link
Contributor

@stephanecopin stephanecopin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -13,7 +13,9 @@ A data source for a `UITableView` or a `UICollectionView` can be constructed by

## Installation

The recommended way to add DataSource to your project is with [Carthage](https://github.com/Carthage/Carthage/releases/).
The recommended way to add DataSource to your project is with CocoaPods. Add `pod 'DataSource', :git => 'https://github.com/Fueled/DataSource.git'` to your Podfile and run `pod install`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather us stay impartial and just include 2 subsections: ### Cocoapods and ### Carthage (in this order). The reason being, Carthage was recommended as an alternative to no dependency management. What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sebsections are a common practice and make it easier to find relevant information (compared to reading text paragraphs).
If you don't want to be impartial you can write ### CocoaPods (recommended) but I don't see a reason for doing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants