Add entity/entity alias primitives #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@suprjinx This is my first Ruby PR, still not sure of all the idioms, so don't hesitate to be harsh, when reviewing. Thanks! |
dave-gantenbein
previously approved these changes
Oct 2, 2024
suprjinx
reviewed
Oct 2, 2024
| err = assert_raises RuntimeError do | ||
| @client.read_entity_alias(@entity_name, @alias_name) | ||
| end | ||
| assert_match /no such entity/, err.message |
suprjinx
reviewed
Oct 2, 2024
suprjinx
reviewed
Oct 2, 2024
test/lib/clients/vault_test.rb
Outdated
| auth_method = "token" | ||
| @client.put_entity_alias(@entity_name, @alias_name, auth_method) | ||
| entity_alias = @client.read_entity_alias(@entity_name, @alias_name) | ||
| assert_equal entity_alias.data[:mount_type], auth_method |
There was a problem hiding this comment.
i think in general the first argument is the expectation, and the second is the actual being tested -- reversed here and in other test above.
https://ruby-doc.org/stdlib-3.0.0/libdoc/minitest/rdoc/Minitest/Assertions.html
|
@suprjinx I've fixed for your comments and the tests are now passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the flaky tests when running rails test, but they appear to be fixed by this PR: #40 , so I didn't address them.