Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simpify config lookups with helper class which checks ENV first, then config #44

Merged
merged 2 commits into from
Oct 3, 2024
Merged

simpify config lookups with helper class which checks ENV first, then config #44

merged 2 commits into from
Oct 3, 2024

Conversation

suprjinx
Copy link
Collaborator

@suprjinx suprjinx commented Oct 3, 2024

So we can look for ENV overrides easily

GeorgeJahad
GeorgeJahad approved these changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@GeorgeJahad GeorgeJahad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@suprjinx suprjinx merged commit 7146eab into G-Research:main Oct 3, 2024
2 checks passed
@suprjinx suprjinx deleted the simplify-config branch October 3, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgeJahad GeorgeJahad GeorgeJahad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suprjinx @GeorgeJahad