pygeosx testing #259
Open
pygeosx testing #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmhan12
force-pushed
the
feature/han12/pygeosx_docker
branch
from
b18ddc2
to
46e3afe
Compare
CusiniM
reviewed
Feb 29, 2024
CusiniM
approved these changes
Feb 29, 2024
TotoGaz
approved these changes
Mar 8, 2024
| with: | ||
| submodules: true | ||
| lfs: true | ||
|
|
||
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@v2 | ||
| uses: docker/setup-buildx-action@v3 |
There was a problem hiding this comment.
@untereiner do you think a dependabot would be useful here as well?
If so, do you mind setting one up?
docker/gcc-ubuntu/Dockerfile
Outdated
| @@ -120,7 +121,15 @@ RUN apt-get install -y --no-install-recommends \ | |||
| libxml2-utils \ | |||
| git \ | |||
| ghostscript \ | |||
| ninja-build | |||
| ninja-build \ | |||
| python3 \ | |||
There was a problem hiding this comment.
I'm not a huge fan of having python hopping in our builds, even for non pygeosx builds... I guess it is what it is.
bmhan12
force-pushed
the
feature/han12/pygeosx_docker
branch
from
3c38f90
to
349faac
Compare
bmhan12
force-pushed
the
feature/han12/pygeosx_docker
branch
from
6114d26
to
0af624a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR installs additional pygeosx dependencies to run pygeosx tests on gcc ubuntu images.
Related to GEOS-DEV/GEOS#2981
Related to GEOS-DEV/LvArray#318