Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#85: Frequency Analysis Word Cloud #94

Open
wants to merge 94 commits into
base: master
Choose a base branch
from
Open

Issue#85: Frequency Analysis Word Cloud #94

wants to merge 94 commits into from

Conversation

favourojo
Copy link
Collaborator

What is the current behavior?

This feature was added to GatorMiner by using the collected data in the words frequency analysis and passing it into a package responsible for creating the word cloud. Once the image has been created, it will be displayed on the Streamlit Web Application using Streamlit's API

What is the new behavior if this PR is merged?

Frequency analysis can now be displayed in a word cloud format to plot the data. This is a new feature that shows another interesting way of plotting word frequency.

Type of change

Please describe the pull request as one of the following:

  • Bug fix
  • Breaking change
  • New feature
  • Documentation update
  • Other

Other information

This PR has:

  • Commit messages that are correctly formatted
  • Tests for newly introduced code
  • Docstrings for newly introduced code

Developers

@solisa986 @hewittk @hadenwIV @donizk @favourojo

solisa986 and others added 30 commits March 30, 2021 19:03
Just updating text mining tool and adding stop  words
… into issue#51

Merge other work on branch with categorization
@hewittk hewittk changed the title Issue#85 Issue#85: Frequency Analysis Word Cloud Apr 28, 2021
@hewittk hewittk added the enhancement New feature or request label Apr 28, 2021
Copy link
Contributor

@enpuyou enpuyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! See the reviews below.

src/analyzer.py Show resolved Hide resolved
src/markdown.py Outdated Show resolved Hide resolved
streamlit_web.py Show resolved Hide resolved
streamlit_web.py Outdated Show resolved Hide resolved
streamlit_web.py Outdated Show resolved Hide resolved
streamlit_web.py Outdated
Comment on lines 316 to 318
wordcloud.to_file("resources/images/word_cloud.png")
st.image("resources/images/word_cloud.png")
os.remove("resources/images/word_cloud.png")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paths are hardcoded.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find any alternative method that displays the wordcloud in streamlit, and saving and displaying an image of the wordcloud seems to be how other people online display it on streamlit. Would there an alternative way to save and display an image that isn't hardcoded?

streamlit_web.py Outdated Show resolved Hide resolved
streamlit_web.py Outdated Show resolved Hide resolved
streamlit_web.py Outdated Show resolved Hide resolved
streamlit_web.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #94 (839e77f) into master (244b0ba) will increase coverage by 0.30%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
+ Coverage   92.09%   92.39%   +0.30%     
==========================================
  Files           6        6              
  Lines         253      263      +10     
==========================================
+ Hits          233      243      +10     
  Misses         20       20              
Impacted Files Coverage Δ
src/analyzer.py 94.89% <100.00%> (+0.57%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Team 8 Team 8 is working on this issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frequency Analysis Word Cloud
7 participants