Make fit_1D behave consistently for data with all (or all but 1) rows masked #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and >1D input with all but one row/column fully masked (ie. only 1 model to fit).
…ded behaviour for fully-masked data.
# Conflicts: # gempy/library/fitting.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How does this look? It should make the behaviour consistent. It's perhaps debatable whether the fitting should return zeroes for fully-masked rows, as in the current behaviour that @saimn implemented to avoid the
NaNproblem, or just try to fit everything, but that's a separate problem from producing the same results for a 1D input whether or not it's part of a model set.