Merge pull request #1 from ifritzler/fix-typescript-keyof-issue

Ensure Type Accuracy in updateSignal Method
Gentleman-Programming · May 18, 2024 · 079705e · 079705e
2 parents c59f1cc + 802cf11
commit 079705e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "gentleman-agnostic-signals",
-  "version": "0.0.4",
+  "version": "0.0.5",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "description": "",

diff --git a/src/init.ts b/src/init.ts
@@ -1,7 +1,7 @@
 import { SignalsManager } from "./signals_manager";
 
 let signalsManager: SignalsManager<any>;
-export type SignalsState<T = {}> = { [K in keyof T]: any };
+export type SignalsState<T = {}> = { [K in keyof T]: T[K] };
 
 export function initSignalsManager<T extends SignalsState<T>>(
   defaultState: T,

diff --git a/src/signals_manager.ts b/src/signals_manager.ts
@@ -1,6 +1,6 @@
 import { Signal, SignalsAdapter, SignalsDomain } from "./domain";
 
-export class SignalsManager<T extends { [K in keyof T]: any }> {
+export class SignalsManager<T extends { [K in keyof T]: T[K] }> {
   signalsCollection = new Map<keyof T, Signal<T[keyof T]>>();
   signalsAdapter: SignalsAdapter<T>;
 
@@ -27,7 +27,7 @@ export class SignalsManager<T extends { [K in keyof T]: any }> {
     return foundSignal;
   }
 
-  updateSignal(key: keyof T, payload: T[keyof T]) {
+  updateSignal<K extends keyof T>(key: K, payload: T[K]) {
     const foundSignal = this.getSignal(key);
 
     this.signalsAdapter.updateSignal(foundSignal, payload);