remove gdal pin #265
Merged
remove gdal pin #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
emmaai
commented
Aug 21, 2023
emmaai
commented
- remove gdal pin
- rebuild the whole image
omad
approved these changes
Aug 22, 2023
|
We probably should try and get this down. |
omad
reviewed
Aug 22, 2023
| @@ -4,7 +4,7 @@ channels: | |||
| dependencies: | |||
| - python=3.8.10 | |||
There was a problem hiding this comment.
Why have we pinned to this specific version of Python 3.8?
It's up to 3.8.17 now, so .10 is quite old.
But, also probably not relevant if we jump up to 3.10 or 3.11. #266
@omad I don't think this is expected - previous integration tests have only taken ~1 hour to complete (still slower than desired due to indexing data on the fly in DEA Notebooks). Looks like there was an issue with code timing out due to something wrong with Dask? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.