Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

free space in workflow #270

Merged
merged 1 commit into from
Oct 4, 2023
Merged

free space in workflow #270

merged 1 commit into from
Oct 4, 2023

Conversation

emmaai
Copy link
Contributor

@emmaai emmaai commented Sep 28, 2023

dive failed due to out of space. The docker image grows for another g after upgrading to python3.10

benjimin
benjimin approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@benjimin benjimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems messy to me - I don't relish the thought of having to maintain this very long list (of library/package names) inside this workflow file, but I support the priority of pragmatically unblocking tests (and maybe revisiting later).

@emmaai emmaai merged commit d60bd1c into develop Oct 4, 2023
3 checks passed
@emmaai emmaai deleted the free_space branch October 4, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjimin benjimin benjimin approved these changes

@omad omad Awaiting requested review from omad

@robbibt robbibt Awaiting requested review from robbibt

@Ariana-B Ariana-B Awaiting requested review from Ariana-B

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emmaai @benjimin