NPI-3311 Fix the clk_diff variable in SISRE function #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User TYTY666 found that there was an issue in how the SISRE clk difference was being calculated.
#19
Specifically, we were not converting to metres in the function (even thought there was a comment saying so).
This PR, therefore, multiplies the
clk_diff
variable by the speed of light to convert to it metres.The minus sign suggest in the user's PR will be investigated separately