Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Npi 3421 Fix nodata formatting of standard deviation columns #35

Merged
merged 5 commits into from
Jul 29, 2024

Conversation

treefern
Copy link
Collaborator

Column names specified for formatter mapping were subtly incorrect. This prevented the relevant formatting function from being invoked.

Also added: minor doc improvements to clarifying nodata handling logic for POS columns.

…andling, to clarify that all components must be 0 to indicate a nodata value.
…getting invoked because the specified column names to use it for, were missing the underscore).
…getting invoked because the specified column names to use it for, were missing the underscore).
…scienceAustralia/gnssanalysis into NPI-3421-improve-sp3-nodata-handling
@treefern treefern requested a review from ronaldmaj July 29, 2024 02:17
Copy link
Collaborator

@ronaldmaj ronaldmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this through. We've discussed this previously and the inclusion of the _ in the STD str for the formatters enables the value to actually be read and outputted.
Good for this to go in 👍

@treefern treefern merged commit 9ad6ee8 into main Jul 29, 2024
1 check passed
@ronaldmaj ronaldmaj deleted the NPI-3421-improve-sp3-nodata-handling branch July 29, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants