NPI-3458 implement solution types utility classes #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronaldmaj
reviewed
Aug 25, 2024
There was a problem hiding this comment.
This looks good to me, adds new code but doesn't alter anything existing so won't cause issues. Plus this will help heaps in our Ops space in making things clearer.
The one thing that could be added are unit tests on these methods, but if this needs to be in the repo to help with testing on Ops, happy for this to go in sooner
…ally and protect against modification of class attributes
ronaldmaj
previously approved these changes
Sep 2, 2024
|
Updated to more robustly work as static classes, preventing modification of class variables. Some other tidying. Addition of unit tests. |
|
A release including this PR, published as |
ronaldmaj
approved these changes
Sep 3, 2024
treefern
deleted the
NPI-3458-implement-solution-types-utility-classes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds utility classes to more formally capture the definitions of solution types defined by IGS. This avoids identifying solution types by short strings throughout the codebase, and allows additional details of each solution type to potentially be captured here as well.